141 Commits
Author SHA1 Message Date
Si Beaumont 97fd57437f Run CMake CI job in a matrix by supported Swift version (#141)
### Motivation:

The CMake CI job in this repo is running using `swift:6.0-jammy`, and
installs CMake from the distro package manager. It doesn't get a very
new CMake and is blocking #140.

We are also missing coverage of our actual supported Swift versions
(currently 6.2 through 6.4).

### Modifications:

Run CMake CI job in a matrix by supported Swift version

### Result:

Replace the CMake CI job running on 6.0 image, with a matrix running on
6.2, 6.3, and 6.4 images.
2026-11-20 10:17:25 +00:00
Charles Zablit 12b0abc194 [CMake] Enable CMP0157 and keep whole-module builds for optimized configs (#139)
Enable CMP0157 so Ninja compiles each Swift module in its own step,
separate from the link. Optimized configurations keep `-wmo`, as under
the old policy.

Tracking: swiftlang/swift#93995

assisted by Claude
2026-11-05 13:44:14 +00:00
Cory Benfield 917b472dbe Correctly apply the end-of-contents octets to the right level (#134)
Motivation

In #125 we attempted to apply a hardening fix that would avoid allowing
truncation of BER content by applying an end-of-contents octets at the
wrong parse depth to a higher-level object. This fix was incomplete.

Modifications

Re-write the code to handle the end-of-contents octets as part of the
loop instead of attempting to detect it after the fact. Add
defense-in-depth for unexpected nodes.

Results

More robust against issues with end-of-contents octets.
1.7.4
2026-10-08 13:02:26 +01:00
apple-ospo[bot] 1964dcaab3 Housekeeping: replace repo-level CODE_OF_CONDUCT (#133)
Replace repo-level CODE_OF_CONDUCT file with the inherited org-wide
[Code of
Conduct](https://github.com/apple/.github/blob/main/CODE_OF_CONDUCT.md)
in .github repo.

Co-authored-by: apple-ospo[bot] <326325757+apple-ospo[bot]@users.noreply.github.com>
2026-10-07 15:41:56 +01:00
Aryan Shah 3b6410f7de Validate base64 content (#131)
### Motivation

We currently ignore unknown characters when parsing the body of a PEM
document. We should also validate whether the body forms a valid base64
encoded string.

### Modifications

- Repurposed the `checkLineLengthsOfBase64EncodedString()` method to
also return the base64 encoded bytes with the line endings removed.
- Updated `LazyPEMDocument` to now require base64 encoded bytes
_without_ line endings.
- Now that the input doesn't have any line endings, the presence of any
non-base64 characters must mean that the input has invalid characters.
- As such, `LazyPEMDocument/decode()` was updated to no longer pass the
[`.ignoreUnknownCharacters`](https://developer.apple.com/documentation/foundation/nsdata/base64decodingoptions/ignoreunknowncharacters)
option to `Data(base64Encoded:)`.
- This means that when the body contains non-base64 characters,
`Data(base64Encoded:)` returns `nil` (we already throw
`ASN1Error.invalidPEMDocument` when receiving `nil`).
 
### Result

Better validation.
1.7.3
2026-09-09 11:43:22 +01:00
Hashim KhanandCory Benfield d9a5b37470 Throw on truncated BER indefinite length encodings (#127)
Fixes #125

A truncated BER indefinite length constructed value was parsed as
success. The last child was popped and treated as the end of contents
marker, so that child disappeared.

The parser now throws truncatedASN1Field when input ends without those
octets, matching X.690 section 8.1.3.6.1.

## Test plan
Added testRejectsTruncatedBERIndefiniteLengthWithoutEndMarker. Built the
SwiftASN1 product. Full XCTest suite needs Xcode.

Co-authored-by: Cory Benfield <lukasa@apple.com>
1.7.2
2026-08-13 14:30:28 +00:00
Cory Benfield c1a7a4e3b3 Updated benchmark thresholds (#128) 2026-08-13 14:58:22 +01:00
aryan-25 a9a5efd40e Encode signed integers correctly (#124)
Motivation:

Currently, positive signed integers whose minimal big-endian
representation exactly fills N bytes (`neededBits % 8 == 0`) have their
top bit misread as the DER sign bit. `Int64(128)` is therefore encoded
as `[0x80]` and decoded back as `-128`. We should fix this.

Modifications:

- Updated the `FixedWidthInteger.neededBytes` implementation to return
`bytes + 1` for positive signed integers in this case, causing
`IntegerBytesCollection` to emit the required `0x00` sign byte.
- Added associated test cases.

Result:

Positive signed integers whose minimal big-endian representation exactly
fills N bytes (`neededBits % 8 == 0`) are now encoded correctly.
1.7.1
2026-05-27 14:29:30 +01:00
Rick Newton-Rogers e3be192d35 Migrate macOS build argument overrides to Swift version inputs (#123)
Motivation

* The shared `macos_tests.yml` workflow no longer accepts
  `xcode_16_2_build_arguments_override` and the `xcode_16_3` input is a
  no-op. Passing the removed input causes CI to fail.
* Older Xcodes are being removed from the runners; Swift version inputs
  are the replacement.

Modifications

* Replace `xcode_16_2/16_3_build_arguments_override` with
  `swift_6_1/6_2/6_3_build_arguments_override` carrying the same
  `-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable` value.

Result

* macOS CI passes again using the Swift version inputs.
2026-05-15 11:30:42 +02:00
LamTrinh.Dev af3440c753 Fix typo in ASN1ObjectIdentifier BER initializer parameter name. (#120)
## Summary
Fix typo in the internal parameter name of
`ASN1ObjectIdentifier.berEncoded(withIdentifier:)` initializer.

  ## Changes
- Rename parameter `identiifer` → `identifier` in
`ASN1ObjectIdentifier.berEncoded(withIdentifier:)`
(ObjectIdentifier.swift:133)

  ## Impact
- The typo only affected the internal parameter name (external label
`withIdentifier` was correct)
  - No functional changes or breaking changes
  - Improves code readability and maintainability

  ## Testing
  - Existing tests continue to pass
  - No behavioral changes
2026-04-16 20:08:47 +00:00
Rick Newton-RogersandGeorge Barnett eb50cbd146 Drop Swift 6.0 (#119)
Motivation:

Swift 6.0 is no longer supported, we should bump the tools version and
remove it from our CI.

Modifications:

* Bump the Swift tools version to Swift 6.1
* Remove Swift 6.0 jobs where appropriate in main.yml, pull_request.yml

Result:

Code reflects our support window.

---------

Co-authored-by: George Barnett <gbarnett@apple.com>
1.7.0
2026-04-08 13:43:17 +01:00
Rick Newton-Rogers 317065bbda Enable Swift 6.3 jobs in CI (#118)
Motivation:

Swift 6.3 has been released, we should add it to our CI coverage.

Modifications:

Add additional Swift 6.3 jobs where appropriate in main.yml,
pull_request.yml

Result:

Improved test coverage.
2026-04-01 13:55:33 +01:00
Mike Drob 9f54261033 Use org security policy instead of our bespoke version (#117) 1.6.0 2026-03-11 18:27:39 +00:00
Rick Newton-Rogers d1c97a8641 update actions/checkout from v4 to v6 (#116)
Motivation

* Following [GitHub's
announcement](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/),
Node 20 is being deprecated and runners will begin using Node 24 by
default starting March 4th, 2026. Node 20 will reach end-of-life in
April 2026.

Modifications

* Upgrade GitHub Actions to their latest versions to ensure
compatibility with Node 24.
* Replace `actions/checkout@v4` with `actions/checkout@v6` in all
workflow files.

Result

* Workflow files reference `actions/checkout@v6`.
2026-03-02 13:33:16 +00:00
mcecundaandCory Benfield 560256f684 Added visible string implementation with tests (#113)
Added missing ASN1 type (ASN1VisibleString) with tests. Implementations
is heavily inspired by existing implementation of ASN1PrintableString.
Differs only in validation rules (_isValid method) and encoding
identifier (defaultIdentifier property).

---------

Co-authored-by: Cory Benfield <lukasa@apple.com>
2026-02-24 16:15:00 +00:00
Rick Newton-Rogers a0b1a7253f switch from main to 0.0.7 for swiftlang workflows (#114)
Motivation

* `@main` references to `swiftlang/github-workflows` are deprecated.

Modifications

* Replace `@main` with `@0.0.7` in all workflow files.

Result

* Workflow files reference a pinned version of
`swiftlang/github-workflows`.
2026-02-23 13:51:54 +00:00
Craz1k0ekandBram Kolkman 810496cf12 Fixed BMPString encoding (#111)
* Fixed #110 by using UTF-16 to encode the string literal
* Added a unit test to test the added functionality

Co-authored-by: Bram Kolkman <bramkolkman@thinkerium.com>
1.5.1
2025-12-01 18:07:08 +00:00
Melissa Kilby 823291a67d chore: restrict GitHub workflow permissions - future-proof (#109)
See https://github.com/swiftlang/github-workflows/issues/167 for
additional context

This approach aligns with security best practices, as detailed in the
following documentation:

-
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
-
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#defining-access-for-the-github_token-scopes
-
https://openssf.org/blog/2024/08/12/mitigating-attack-vectors-in-github-workflows/


The default GITHUB_TOKEN permissions are defined at the repository
level. This PR modifies the workflow-level overrides to conform to
OpenSSF best practices -> defense in depth.

Allow me to quote OpenSSF:

https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

> The highest score is awarded when the permissions definitions in each
workflow's yaml file are set as read-only at the top level and the
required write permissions are declared at the run-level.”

> Remediation steps
> - Set top-level permissions as read-all or contents: read as described
in GitHub's documentation.
> - Set any required write permissions at the job-level. Only set the
permissions required for that job; do not set permissions: write-all at
the job level.


Compare to the LLVM project:

Top-level: contents read, e.g.
https://github.com/swiftlang/llvm-project/blob/next/.github/workflows/build-ci-container-windows.yml#L3-L4
-> this makes it future-proof

Job-level: Allow write permissions as needed, e.g.
https://github.com/swiftlang/llvm-project/blob/next/.github/workflows/build-ci-container-windows.yml#L53-L58

Signed-off-by: Melissa Kilby <mkilby@apple.com>
2025-10-20 08:51:15 +01:00
Orhan Yigit Yazicilar 40d25bbb2f Drop Swift 5.10 (#108)
### Motivation:

Swift 5.10 is no longer supported, we should bump the swift-tools
version.

### Modifications:

* Update Swift tools version to 6.0
* Add `strictConcurrencyDevelopment` mode

### Result:

Code reflects our support window.
1.5.0
2025-09-25 13:45:05 +01:00
Rick Newton-Rogers 348b60eb35 Enable Swift 6.2 jobs in CI (#107)
Motivation:

Swift 6.2 has been released, we should add it to our CI coverage.

Modifications:

Add additional Swift 6.2 jobs where appropriate in main.yml,
pull_request.yml

Result:

Improved test coverage.
2025-09-22 14:28:23 +01:00
Raphael 6bbdf5fb8b Enable release mode builds (#105)
### Motivation:

Some errors do not show up in debug builds. Enabling release mode builds
improves the CI coverage.

### Modifications:

Enable release mode builds for pull requests and scheduled builds on
main.

### Result:

Improved CI coverage.
2025-07-30 08:59:50 +01:00
Rafael CepedaandGeorge Barnett f702259812 Introduced -Xswiftc -Xfrontend flag to GA workflow. (#104)
Introduced -Xswiftc -Xfrontend flag to GA workflow. There were no
Sendability warnings to fix after this change.

---------

Co-authored-by: George Barnett <gbarnett@apple.com>
1.4.0
2025-06-20 12:57:05 +01:00
Evan Wilde 078ef3316a Install swiftmodules with full module triple (#103)
Clean up how the CMake build installs swiftmodules, using the full
module triple instead of just the architecture. This change uses the
compiler to compute the expected module triple instead of attempting to
compute it in CMake script. This is more maintainable and robust to
adding new platforms and architectures.
2025-05-14 04:49:00 +00:00
Rick Newton-Rogers bb75fd81b3 Drop Swift 5.9 (#102)
Motivation:

Swift 5.9 is no longer supported, we should bump the tools version and
remove it from our CI.

Modifications:

* Bump the Swift tools version to Swift 5.10
* Remove Swift 5.9 jobs where appropriate in main.yml, pull_request.yml

Result:

Code reflects our support window.
2025-04-29 15:32:34 +01:00
Rick Newton-Rogers a54383ada6 add thresholds for Swift 6.1 from 6.0 thresholds (#101)
- **Enable Swift 6.1 jobs in CI**
- **add thresholds for Swift 6.1 from 6.0 thresholds**
1.3.2
2025-04-14 12:00:45 +01:00
Rick Newton-Rogers 15fb892c05 Enable Swift 6.1 jobs in CI (#99)
Motivation:

Swift 6.1 has been released, we should add it to our CI coverage.

Modifications:

Add additional Swift 6.1 jobs where appropriate in main.yml,
pull_request.yml

Result:

Improved test coverage.
2025-04-14 10:47:03 +01:00
Rick Newton-Rogers d1b6295fef Enable macOS CI on pull requests (#98)
Motivation:

* Improve test coverage

Modifications:

Enable macOS CI to be run on pull request commits and make the use of
the nightly runner pool for main.yml jobs explicit.

Result:

Improved test coverage.
2025-04-01 17:41:09 +01:00
Rick Newton-Rogers 945d24b4c6 Enable macOS CI on merge to main and daily timer (#97)
Motivation:

* Improve test coverage
* Check test pass/fail status
* Monitor CI throughput

Modifications:

Enable macOS CI to be run on all merges to main and on a daily timer.

Result:

Improved test coverage run out-of-band at the moment so we can get a
feeling for if any changes need to be made in the repo or in the CI
pipelines to ensure timely and stable checks.
2025-03-28 15:12:04 +00:00
Rick Newton-Rogers 6578d7acfc Use centralized CMake checks (#96)
### Motivation:

We now have centrally-hosted CMake checks in the NIO repository which we
should use to reduce maintenance. The new checks also increase coverage
by performing a build with CMake as part of the checks.

### Modifications:

* Use the new workflow
* Commit formatting changes in the CMakeLists files from the new script
* Document how to update the CMakeLists files
* Remove the obsolete scripts

### Result:

Better CI coverage.
2025-03-17 11:15:52 +00:00
Rick Newton-Rogers 6cac4d424c Add static SDK CI workflow (#95)
Add static SDK CI workflow which runs on commits to PRs, merges to main
and daily on main.
2025-03-13 11:02:10 +00:00
Rick Newton-Rogers 3e5252c581 Only apply standard swift settings on valid targets (#94)
Only apply standard swift settings on valid targets. The current check
ignores plugins but that is not comprehensive enough.
2025-03-07 15:04:27 +00:00
Rick Newton-Rogers cc8d801730 Delete Thresholds/nightly-6.1 symlink (#93)
Following on from https://github.com/apple/swift-asn1/pull/92 delete
`Thresholds/nightly-6.1` which is no longer needed now that the shared
benchmarks workflow has been updated
2025-03-07 12:10:31 +00:00
Rick Newton-Rogers e0c82abd86 move nightly-next thresholds and add legacy symlink (#92)
Move nightly-next thresholds and add legacy symlink; see
https://github.com/apple/swift-nio/pull/3122
2025-03-03 15:27:11 +00:00
Rick Newton-Rogers 9fb1b88a90 Rename nightly_6_1 params to nightly_next (#91)
Rename nightly_6_1 params to nightly_next; see
https://github.com/apple/swift-nio/pull/3122
2025-03-03 14:50:35 +00:00
Gus Cairo 77d6ab4537 Import FoundationEssentials instead of Foundation when available (#89)
`FoundationEssentials` is more lightweight than `Foundation`, and so we
should switch to importing it when possible.
2025-02-24 11:39:35 +00:00
Rick Newton-Rogers 82d28dbe21 CI use 6.1 nightlies (#87)
CI use 6.1 nightlies now that Swift development is happening in the 6.1
branch
2025-01-30 09:44:09 +00:00
David Nadoba 9cbe88dedd Move nightly-6.0 benchmark thresholds to 6.1 (#86)
6.0 nightly is gone. 6.1 was added somehow. Haven't found a PR for that
though. Not sure how that has changed.
2025-01-25 08:33:01 +00:00
michael-yuji 24d6a08b2e fix amd64 support (#85)
Fix when "${CMAKE_SYSTEM_PROCESSOR}" is lowercase "amd64"
2025-01-24 10:09:53 -08:00
Cory BenfieldandNicolas Bachschmidt ae33e5941b Merge commit from fork
* Throw error instead of halting when the encoding is invalid

Signed-off-by: Cory Benfield <lukasa@apple.com>

* Avoid extra precondition failure

---------

Signed-off-by: Cory Benfield <lukasa@apple.com>
Co-authored-by: Nicolas Bachschmidt <nicolas@nunk.net>
1.3.1
2025-01-14 14:18:46 +00:00
Franz Busch c27bcbd7ec Update release.yml (#84)
Update the release.yml file with the latest label changes
2024-12-18 14:14:56 +01:00
Rick Newton-Rogers fe261eeb42 Enable MemberImportVisibility check on all targets (#83)
Enable MemberImportVisibility check on all targets. Use a standard
string header and footer to bracket the new block for ease of updating
in the future with scripts.
2024-12-13 15:11:01 +01:00
Franz Busch 15a8a271b4 Aligning semantic version label check name (#82) 2024-11-28 12:47:15 +01:00
Rick Newton-RogersandCory Benfield e647aabfb8 unify scheduled and main yamls (#79)
Co-authored-by: Cory Benfield <lukasa@apple.com>
2024-11-15 11:17:47 +00:00
Rick Newton-Rogers b65ee9bc34 add .editorconfig file (#80) 2024-11-14 15:59:53 +00:00
Franz Busch 892b611455 [CI] Enable Windows CI (#77)
# Motivation

We want to make sure our packages build on all supported platforms.

# Modification

This PR enabled the Windows CI.

# Result

Better test coverage in our package.
2024-10-23 10:43:11 +01:00
Peter Adams 8f3abb33b0 Remove script for updating contributors list (#78)
Motivation:

Contributors list is nolonger being maintained
as it can be trivially derived from git history.

Modifications:

Remove script for updating contributors list.

Result:

One fewer script
2024-10-22 16:38:52 +01:00
Rick Newton-Rogers 81ee7dc715 CI: concurrency=complete require-explicit-sendable (#76)
CI: concurrency=complete require-explicit-sendable

Motivation:

Adopt `-Xswiftc -strict-concurrency=complete -Xswiftc
-require-explicit-sendable` in CI to lock-in concurrency-safety wins.

Modifications:

Added strict flags to pull request and scheduled GHA CI on Swift 6.0.

Result:

CI should ensure we don't regress data-race safety on Swift 6.0.
2024-10-17 09:36:37 +01:00
Rick Newton-Rogers b4353f4ec9 Remove legacy CI docker/script files (#75)
Motivation:

Now that we have cut over to GitHub Actions we can remove files
supporting the old workflow.

Modifications:

Remove docker and stubbed-out script files.

Result:

Nothing should change because GHA is now used as CI.
2024-10-15 14:32:08 +01:00
Rick Newton-Rogers d016643222 Migrate to GitHub Actions reusable workflows (2) (#74)
* Prepare repo for new GHA checks

Motivation:

Migrate to GitHub Actions reusable workflows (2)

Modifications:

* Add GHA PR label checks
* Add GHA benchmarks checks
* Satisfy soundness checks

Result:

New soundness checks should be green and ready for adoption

* review comments
2024-10-15 13:04:58 +01:00
Cory Benfield 7faebca1ea Drop Swift 5.8 (#69)
We no longer support Swift 5.8, so let's wave it goodbye
1.3.0
2024-10-14 11:13:45 +00:00