mirror of
https://github.com/apple/swift-nio
synced 2026-11-22 04:30:41 +00:00
Fix benchmark diff scraping for path-qualified markers (#3609)
## Motivation `scripts/check_benchmark_thresholds.sh` started printing path-qualified diff markers in #3602 so multi-package benchmark runs can identify which package produced each diff. `dev/thresholds-from-benchmark-output.sh` still scrapes the old exact marker line, which means local threshold updates from CI logs can miss the diff entirely once the new marker format appears. ## Changes Relax the scraper to match the stable `=== BEGIN DIFF` prefix instead of the old exact line, preserving compatibility with both the original marker and the newer path-qualified form. ## Validation - `bash -n dev/thresholds-from-benchmark-output.sh` - Verified the scrape pipeline against both `=== BEGIN DIFF ===` and `=== BEGIN DIFF (Benchmarks) ===` sample log lines Co-authored-by: Cory Benfield <lukasa@apple.com>
This commit is contained in:
1 parent
0b38af6217
commit
a863732fbc
1 file changed
+1
-1
@@ -118,7 +118,7 @@ scrape_benchmarks_output_diff() {
|
||||
|
||||
log "Scraping diff from log"
|
||||
# Trim out everything but the diff
|
||||
git_diff="$(echo "$lines" | sed '1,/=== BEGIN DIFF ===/d' | sed '/Post job cleanup/,$d' | sed 's/^[0-9][0-9][0-9][0-9]-.*Z //')"
|
||||
git_diff="$(echo "$lines" | sed '1,/^=== BEGIN DIFF/d' | sed '/Post job cleanup/,$d' | sed 's/^[0-9][0-9][0-9][0-9]-.*Z //')"
|
||||
|
||||
echo "$git_diff"
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user