mirror of
https://github.com/apple/swift-nio-ssl
synced 2026-11-22 04:30:44 +00:00
Demote ImplementationOnlyDeprecated warning in main CI (#586)
The Main CI workflow currently fails on Swift 6.1, 6.2, and 6.3 because `-Xswiftc -warnings-as-errors` is enabled, while the `@_implementationOnly` imports in this codebase emit deprecation warnings (`ImplementationOnlyDeprecated`). The PR workflow already handles this correctly; this change brings the main workflow in line. Specifically: - 6.1: Drops `-warnings-as-errors` entirely, since this toolchain doesn't support demoting the ImplementationOnlyDeprecated warning. A comment explains why. - 6.2 / 6.3: Adds `-Xswiftc -Wwarning -Xswiftc` ImplementationOnlyDeprecated to demote the warning while still failing on other warnings.
This commit is contained in:
1 parent
73f8803df4
commit
407d82d5b6
1 file changed
+4
-3
@@ -15,9 +15,10 @@ jobs:
|
||||
uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
|
||||
with:
|
||||
linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error"
|
||||
linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
linux_6_3_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
# We can't set warnings-as-errors for 6.1 because we can't suppress the ImplementationOnly import warning.
|
||||
linux_6_1_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors -Xswiftc -Wwarning -Xswiftc ImplementationOnlyDeprecated --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
linux_6_3_arguments_override: "-Xswiftc -warnings-as-errors -Xswiftc -Wwarning -Xswiftc ImplementationOnlyDeprecated --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
|
||||
|
||||
|
||||
Reference in new issue
Block a user