mirror of
https://github.com/apple/swift-certificates
synced 2026-11-22 04:20:39 +00:00
Add directory name constraints. (#44)
Just to round things out we can add directory name constraints. There's nominally a fairly complex algorithm for validating directory name constraints, but most implementations don't bother, instead falling back to direct matches.
This commit is contained in:
1 parent
7816361861
commit
83af4ff3ca
3 files changed
+77
No files matched your search
@@ -75,6 +75,7 @@ add_library(X509
|
||||
"Verifier/CertificateStore.swift"
|
||||
"Verifier/RFC5280/BasicConstraintsPolicy.swift"
|
||||
"Verifier/RFC5280/DNSNames.swift"
|
||||
"Verifier/RFC5280/DirectoryNames.swift"
|
||||
"Verifier/RFC5280/ExpiryPolicy.swift"
|
||||
"Verifier/RFC5280/IPConstraints.swift"
|
||||
"Verifier/RFC5280/NameConstraintsPolicy.swift"
|
||||
|
||||
@@ -0,0 +1,25 @@
|
||||
//===----------------------------------------------------------------------===//
|
||||
//
|
||||
// This source file is part of the SwiftCertificates open source project
|
||||
//
|
||||
// Copyright (c) 2023 Apple Inc. and the SwiftCertificates project authors
|
||||
// Licensed under Apache License v2.0
|
||||
//
|
||||
// See LICENSE.txt for license information
|
||||
// See CONTRIBUTORS.txt for the list of SwiftCertificates project authors
|
||||
//
|
||||
// SPDX-License-Identifier: Apache-2.0
|
||||
//
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
extension NameConstraintsPolicy {
|
||||
/// Validates that a directory name matches a name constraint.
|
||||
///
|
||||
/// There's a complex algorithm for doing proper directory name constraints validation.
|
||||
/// However, most implementations don't bother, and just directly compare the distinguished
|
||||
/// names.
|
||||
@inlinable
|
||||
static func directoryNameMatchesConstraint(directoryName: DistinguishedName, constraint: DistinguishedName) -> Bool {
|
||||
return directoryName == constraint
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,51 @@
|
||||
//===----------------------------------------------------------------------===//
|
||||
//
|
||||
// This source file is part of the SwiftCertificates open source project
|
||||
//
|
||||
// Copyright (c) 2023 Apple Inc. and the SwiftCertificates project authors
|
||||
// Licensed under Apache License v2.0
|
||||
//
|
||||
// See LICENSE.txt for license information
|
||||
// See CONTRIBUTORS.txt for the list of SwiftCertificates project authors
|
||||
//
|
||||
// SPDX-License-Identifier: Apache-2.0
|
||||
//
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
import XCTest
|
||||
import SwiftASN1
|
||||
@testable import X509
|
||||
|
||||
final class NameConstraintsTests: XCTestCase {
|
||||
func testDirectoryNameMatches() throws {
|
||||
// The key here is that a distinguished name only matches a constraint if they're equal.
|
||||
let names: [DistinguishedName] = [
|
||||
try DistinguishedName {
|
||||
CountryName("US")
|
||||
StateOrProvinceName("CA")
|
||||
OrganizationName("Apple")
|
||||
},
|
||||
try DistinguishedName {
|
||||
CountryName("US")
|
||||
StateOrProvinceName("CA")
|
||||
OrganizationName("Apple")
|
||||
CommonName("Test")
|
||||
},
|
||||
try DistinguishedName {
|
||||
CountryName("GB")
|
||||
OrganizationName("Apple")
|
||||
CommonName("Test")
|
||||
},
|
||||
]
|
||||
|
||||
for firstName in names {
|
||||
for secondName in names {
|
||||
XCTAssertEqual(
|
||||
NameConstraintsPolicy.directoryNameMatchesConstraint(directoryName: firstName, constraint: secondName),
|
||||
firstName == secondName,
|
||||
"Expected directory name match to be \(firstName == secondName) for \(firstName) and \(secondName)"
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user