Our perf thresholds have changed (#178)

* Our perf thresholds have changed

* Apparently local runs don't match

* Stop using retain/release thresholds

* Remove retain/release counts
This commit is contained in:
Cory Benfield authored and GitHub committed 2024-06-07 16:27:37 +01:00
1 parent d93756ba92
commit 4688f24281
26 files changed
+30 -76

No files matched your search

@@ -23,16 +23,10 @@ let benchmarks = {
.readSyscalls,
.writeSyscalls,
.memoryLeaked,
.retainCount,
.releaseCount,
]
)
var configWithoutRetainRelease = Benchmark.defaultConfiguration
configWithoutRetainRelease.metrics.removeAll(where: { $0 == .retainCount || $0 == .releaseCount })
// async code is currently still quite flaky in the number of retain/release it does so we don't measure them today
Benchmark("Verifier", configuration: configWithoutRetainRelease) { benchmark in
Benchmark("Verifier") { benchmark in
for _ in benchmark.scaledIterations {
await verifier()
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 5506,
"mallocCountTotal" : 4851,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 120084,
"retainCount" : 108506,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6465,
"mallocCountTotal" : 5810,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 133927,
"retainCount" : 120568,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6473,
"mallocCountTotal" : 5818,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 133256,
"retainCount" : 120160,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 10,
"mallocCountTotal" : 26,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 12,
"retainCount" : 0,
"writeSyscalls" : 0
}
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 0,
"mallocCountTotal" : 16,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 0,
"retainCount" : 0,
"writeSyscalls" : 0
}
@@ -1,5 +1,5 @@
{
"mallocCountTotal" : 1233,
"mallocCountTotal" : 1249,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"writeSyscalls" : 0
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 5506,
"mallocCountTotal" : 4851,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 190789,
"retainCount" : 180211,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6465,
"mallocCountTotal" : 5810,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 208611,
"retainCount" : 196252,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6473,
"mallocCountTotal" : 5818,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 207940,
"retainCount" : 195844,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 10,
"mallocCountTotal" : 26,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 12,
"retainCount" : 0,
"writeSyscalls" : 0
}
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 0,
"mallocCountTotal" : 16,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 1,
"retainCount" : 0,
"writeSyscalls" : 0
}
@@ -1,5 +1,5 @@
{
"mallocCountTotal" : 1234,
"mallocCountTotal" : 1250,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"writeSyscalls" : 0
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 5506,
"mallocCountTotal" : 4851,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 185130,
"retainCount" : 174552,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6465,
"mallocCountTotal" : 5810,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 199110,
"retainCount" : 186751,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6473,
"mallocCountTotal" : 5818,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 198439,
"retainCount" : 186343,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 10,
"mallocCountTotal" : 26,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 12,
"retainCount" : 0,
"writeSyscalls" : 0
}
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 0,
"mallocCountTotal" : 16,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 1,
"retainCount" : 0,
"writeSyscalls" : 0
}
@@ -1,5 +1,5 @@
{
"mallocCountTotal" : 1233,
"mallocCountTotal" : 1249,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"writeSyscalls" : 0
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 5506,
"mallocCountTotal" : 4851,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 121084,
"retainCount" : 109506,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6465,
"mallocCountTotal" : 5810,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 134927,
"retainCount" : 121568,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 6473,
"mallocCountTotal" : 5818,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 134256,
"retainCount" : 121160,
"writeSyscalls" : 0
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 10,
"mallocCountTotal" : 26,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 12,
"retainCount" : 0,
"writeSyscalls" : 0
}
}
@@ -1,8 +1,6 @@
{
"mallocCountTotal" : 0,
"mallocCountTotal" : 16,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"releaseCount" : 0,
"retainCount" : 0,
"writeSyscalls" : 0
}
@@ -1,5 +1,5 @@
{
"mallocCountTotal" : 1233,
"mallocCountTotal" : 1251,
"memoryLeaked" : 0,
"readSyscalls" : 0,
"writeSyscalls" : 0
+1 -1
View File
@@ -19,7 +19,7 @@ set -o pipefail
here="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
target_repo=${2-"$here/.."}
for f in 57 58 59 510 -nightly; do
for f in 58 59 510 -nightly; do
echo "swift$f"
docker_file=$(if [[ "$f" == "-nightly" ]]; then f=main; fi && ls "$target_repo/docker/docker-compose."*"$f"*".yaml")