mirror of
https://github.com/groue/GRDB.swift
synced 2026-11-22 04:00:39 +00:00
Failing tests for decoding and encoding strings with a NUL character
Inspired from #1880 by @nesevis
This commit is contained in:
1 parent
5d31cba4a0
commit
dfa942e9c0
1 file changed
+130
@@ -28,6 +28,8 @@ private let emojiData = emojiString.data(using: .utf8)
|
||||
private let nonUTF8Data = Data([0x80])
|
||||
private let invalidString = "\u{FFFD}" // decoded from nonUTF8Data
|
||||
private let jpegData = try! Data(contentsOf: testBundle.url(forResource: "Betty", withExtension: "jpeg")!)
|
||||
private let nulString = "foo\u{0}bar" // https://sqlite.org/nulinstr.html
|
||||
private let nulStringData = nulString.data(using: .utf8)
|
||||
|
||||
class DatabaseValueConversionTests : GRDBTestCase {
|
||||
|
||||
@@ -253,6 +255,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulString is turned to Text
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (textAffinity) VALUES (?)", arguments: [nulString])
|
||||
let sql = "SELECT textAffinity FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .text)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// emojiData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -269,6 +287,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulStringData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (textAffinity) VALUES (?)", arguments: [nulStringData])
|
||||
let sql = "SELECT textAffinity FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .blob)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nonUTF8Data is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -512,6 +546,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulString is turned to Text
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (realAffinity) VALUES (?)", arguments: [nulString])
|
||||
let sql = "SELECT realAffinity FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .text)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// emojiData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -528,6 +578,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulStringData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (realAffinity) VALUES (?)", arguments: [nulStringData])
|
||||
let sql = "SELECT realAffinity FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .blob)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nonUTF8Data is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -699,6 +765,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulString is turned to Text
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (noneAffinity) VALUES (?)", arguments: [nulString])
|
||||
let sql = "SELECT noneAffinity FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .text)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// emojiData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -715,6 +797,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nullStringData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (noneAffinity) VALUES (?)", arguments: [nulStringData])
|
||||
let sql = "SELECT noneAffinity FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .blob)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nonUTF8Data is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -932,6 +1030,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulString is turned to Text
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (\(columnName)) VALUES (?)", arguments: [nulString])
|
||||
let sql = "SELECT \(columnName) FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .text)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// emojiData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
@@ -948,6 +1062,22 @@ class DatabaseValueConversionTests : GRDBTestCase {
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nulStringData is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
try db.execute(sql: "INSERT INTO `values` (\(columnName)) VALUES (?)", arguments: [nulStringData])
|
||||
let sql = "SELECT \(columnName) FROM `values`"
|
||||
XCTAssertEqual(try DatabaseValue.fetchOne(db, sql: sql)!.storageClass, .blob)
|
||||
try assertDecoding(db, sql, Bool.self, expectedSQLiteConversion: false, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int.self, expectedSQLiteConversion:0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int32.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Int64.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, Double.self, expectedSQLiteConversion: 0, expectedDatabaseValueConversion: nil)
|
||||
try assertDecoding(db, sql, String.self, expectedSQLiteConversion: nulString, expectedDatabaseValueConversion: nulString)
|
||||
try assertDecoding(db, sql, Data.self, expectedSQLiteConversion: nulStringData, expectedDatabaseValueConversion: nulStringData)
|
||||
return .rollback
|
||||
}
|
||||
|
||||
// nonUTF8Data is turned to Blob
|
||||
|
||||
try dbQueue.inTransaction { db in
|
||||
|
||||
Reference in new issue
Block a user