mirror of
https://github.com/groue/GRDB.swift
synced 2026-11-22 04:00:39 +00:00
Failing tests for INTEGER PRIMARY KEY in WITHOUT ROWID tables
This commit is contained in:
1 parent
0d8cf958b4
commit
d4713c1fa8
3 files changed
+180
No files matched your search
@@ -105,6 +105,36 @@ class PrimaryKeyInfoTests: GRDBTestCase {
|
||||
}
|
||||
}
|
||||
|
||||
func testIntegerPrimaryKeyWithoutRowID() throws {
|
||||
let dbQueue = try makeDatabaseQueue()
|
||||
try dbQueue.inDatabase { db in
|
||||
try db.execute(sql: "CREATE TABLE items (id INTEGER PRIMARY KEY, name TEXT) WITHOUT ROWID")
|
||||
let primaryKey = try db.primaryKey("items")
|
||||
XCTAssertEqual(primaryKey.columnInfos?.map(\.name), ["id"])
|
||||
XCTAssertEqual(primaryKey.columnInfos?.map(\.type), ["INTEGER"])
|
||||
XCTAssertEqual(primaryKey.columns, ["id"])
|
||||
// An INTEGER primary key is an alias for the rowid in rowid
|
||||
// tables only: https://www.sqlite.org/lang_createtable.html
|
||||
XCTAssertNil(primaryKey.rowIDColumn)
|
||||
XCTAssertFalse(primaryKey.isRowID)
|
||||
XCTAssertFalse(primaryKey.tableHasRowID)
|
||||
}
|
||||
}
|
||||
|
||||
func testIntegerPrimaryKeyWithoutRowID2() throws {
|
||||
let dbQueue = try makeDatabaseQueue()
|
||||
try dbQueue.inDatabase { db in
|
||||
try db.execute(sql: "CREATE TABLE items (id INTEGER, name TEXT, PRIMARY KEY (id)) WITHOUT ROWID")
|
||||
let primaryKey = try db.primaryKey("items")
|
||||
XCTAssertEqual(primaryKey.columnInfos?.map(\.name), ["id"])
|
||||
XCTAssertEqual(primaryKey.columnInfos?.map(\.type), ["INTEGER"])
|
||||
XCTAssertEqual(primaryKey.columns, ["id"])
|
||||
XCTAssertNil(primaryKey.rowIDColumn)
|
||||
XCTAssertFalse(primaryKey.isRowID)
|
||||
XCTAssertFalse(primaryKey.tableHasRowID)
|
||||
}
|
||||
}
|
||||
|
||||
func testNonRowIDPrimaryKeyWithoutRowID() throws {
|
||||
let dbQueue = try makeDatabaseQueue()
|
||||
try dbQueue.inDatabase { db in
|
||||
|
||||
@@ -2388,6 +2388,81 @@ extension MutablePersistableRecordTests {
|
||||
}
|
||||
}
|
||||
|
||||
func test_upsert_INTEGER_primary_key_WITHOUT_ROWID() throws {
|
||||
#if GRDBCUSTOMSQLITE || SQLITE_HAS_CODEC
|
||||
guard Database.sqliteLibVersionNumber >= 3035000 else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#else
|
||||
guard #available(iOS 15, macOS 12, tvOS 15, watchOS 8, *) else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#endif
|
||||
|
||||
struct MyRecord: Codable, FetchableRecord, MutablePersistableRecord {
|
||||
var id: Int64
|
||||
var name: String
|
||||
}
|
||||
|
||||
try makeDatabaseQueue().write { db in
|
||||
try db.execute(sql: """
|
||||
CREATE TABLE myRecord(
|
||||
id INTEGER PRIMARY KEY,
|
||||
name TEXT NOT NULL
|
||||
) WITHOUT ROWID;
|
||||
""")
|
||||
|
||||
var record = MyRecord(id: 1, name: "foo")
|
||||
try record.upsert(db)
|
||||
|
||||
XCTAssertEqual(lastSQLQuery, """
|
||||
INSERT INTO "myRecord" ("id", "name") \
|
||||
VALUES (1,'foo') \
|
||||
ON CONFLICT DO UPDATE SET "name" = "excluded"."name"
|
||||
""")
|
||||
}
|
||||
}
|
||||
|
||||
func test_upsertAndFetch_INTEGER_primary_key_WITHOUT_ROWID() throws {
|
||||
#if GRDBCUSTOMSQLITE || SQLITE_HAS_CODEC
|
||||
guard Database.sqliteLibVersionNumber >= 3035000 else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#else
|
||||
guard #available(iOS 15, macOS 12, tvOS 15, watchOS 8, *) else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#endif
|
||||
|
||||
struct MyRecord: Codable, FetchableRecord, MutablePersistableRecord {
|
||||
var id: Int64
|
||||
var name: String
|
||||
}
|
||||
|
||||
try makeDatabaseQueue().write { db in
|
||||
try db.execute(sql: """
|
||||
CREATE TABLE myRecord(
|
||||
id INTEGER PRIMARY KEY,
|
||||
name TEXT NOT NULL
|
||||
) WITHOUT ROWID;
|
||||
""")
|
||||
|
||||
var record = MyRecord(id: 1, name: "foo")
|
||||
let upserted = try record.upsertAndFetch(db)
|
||||
|
||||
// No rowid in the RETURNING clause: the table has none
|
||||
XCTAssertEqual(lastSQLQuery, """
|
||||
INSERT INTO "myRecord" ("id", "name") \
|
||||
VALUES (1,'foo') \
|
||||
ON CONFLICT DO UPDATE SET "name" = "excluded"."name" \
|
||||
RETURNING *
|
||||
""")
|
||||
|
||||
XCTAssertEqual(upserted.id, 1)
|
||||
XCTAssertEqual(upserted.name, "foo")
|
||||
}
|
||||
}
|
||||
|
||||
func test_upsertAndFetch_do_update_set_where_with_default_strategy() throws {
|
||||
#if GRDBCUSTOMSQLITE || SQLITE_HAS_CODEC
|
||||
guard Database.sqliteLibVersionNumber >= 3035000 else {
|
||||
|
||||
@@ -2378,6 +2378,81 @@ extension PersistableRecordTests {
|
||||
}
|
||||
}
|
||||
|
||||
func test_upsert_INTEGER_primary_key_WITHOUT_ROWID() throws {
|
||||
#if GRDBCUSTOMSQLITE || SQLITE_HAS_CODEC
|
||||
guard Database.sqliteLibVersionNumber >= 3035000 else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#else
|
||||
guard #available(iOS 15, macOS 12, tvOS 15, watchOS 8, *) else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#endif
|
||||
|
||||
struct MyRecord: Codable, FetchableRecord, PersistableRecord {
|
||||
var id: Int64
|
||||
var name: String
|
||||
}
|
||||
|
||||
try makeDatabaseQueue().write { db in
|
||||
try db.execute(sql: """
|
||||
CREATE TABLE myRecord(
|
||||
id INTEGER PRIMARY KEY,
|
||||
name TEXT NOT NULL
|
||||
) WITHOUT ROWID;
|
||||
""")
|
||||
|
||||
let record = MyRecord(id: 1, name: "foo")
|
||||
try record.upsert(db)
|
||||
|
||||
XCTAssertEqual(lastSQLQuery, """
|
||||
INSERT INTO "myRecord" ("id", "name") \
|
||||
VALUES (1,'foo') \
|
||||
ON CONFLICT DO UPDATE SET "name" = "excluded"."name"
|
||||
""")
|
||||
}
|
||||
}
|
||||
|
||||
func test_upsertAndFetch_INTEGER_primary_key_WITHOUT_ROWID() throws {
|
||||
#if GRDBCUSTOMSQLITE || SQLITE_HAS_CODEC
|
||||
guard Database.sqliteLibVersionNumber >= 3035000 else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#else
|
||||
guard #available(iOS 15, macOS 12, tvOS 15, watchOS 8, *) else {
|
||||
throw XCTSkip("UPSERT is not available")
|
||||
}
|
||||
#endif
|
||||
|
||||
struct MyRecord: Codable, FetchableRecord, PersistableRecord {
|
||||
var id: Int64
|
||||
var name: String
|
||||
}
|
||||
|
||||
try makeDatabaseQueue().write { db in
|
||||
try db.execute(sql: """
|
||||
CREATE TABLE myRecord(
|
||||
id INTEGER PRIMARY KEY,
|
||||
name TEXT NOT NULL
|
||||
) WITHOUT ROWID;
|
||||
""")
|
||||
|
||||
let record = MyRecord(id: 1, name: "foo")
|
||||
let upserted = try record.upsertAndFetch(db)
|
||||
|
||||
// No rowid in the RETURNING clause: the table has none
|
||||
XCTAssertEqual(lastSQLQuery, """
|
||||
INSERT INTO "myRecord" ("id", "name") \
|
||||
VALUES (1,'foo') \
|
||||
ON CONFLICT DO UPDATE SET "name" = "excluded"."name" \
|
||||
RETURNING *
|
||||
""")
|
||||
|
||||
XCTAssertEqual(upserted.id, 1)
|
||||
XCTAssertEqual(upserted.name, "foo")
|
||||
}
|
||||
}
|
||||
|
||||
func test_upsertAndFetch_do_update_set_where_with_default_strategy() throws {
|
||||
#if GRDBCUSTOMSQLITE || SQLITE_HAS_CODEC
|
||||
guard Database.sqliteLibVersionNumber >= 3035000 else {
|
||||
|
||||
Reference in new issue
Block a user