From fa6a245b375437ca4884b564687f08b08ee8d8e7 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 6 Nov 2026 12:05:41 +0000 Subject: [PATCH 1/3] [CMake] Require CMake 3.29 to enable CMP0157 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index df64729..956769f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -7,7 +7,7 @@ Licensed under Apache License v2.0 with Runtime Library Exception See https://swift.org/LICENSE.txt for license information #]] -cmake_minimum_required(VERSION 3.16.0) +cmake_minimum_required(VERSION 3.29) project(SwiftSystem LANGUAGES C Swift) From 2949c1bfcb1c23afe0858b0cdcc05a2950a95d6a Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 13 Nov 2026 16:56:07 +0100 Subject: [PATCH 2/3] [CI] Install CMake 4.0.2 for CMake validation --- .github/workflows/pull_request.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 07505bd..1312f7f 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -75,7 +75,10 @@ jobs: uses: actions/checkout@v6 - name: Install Dependencies shell: bash - run: apt update && apt install -y cmake ninja-build jq + run: | + apt update && apt install -y curl ninja-build jq + curl -fsSL "https://github.com/Kitware/CMake/releases/download/v4.0.2/cmake-4.0.2-linux-$(uname -m).tar.gz" \ + | tar --strip-components=1 -xz -C /usr/local - name: Configure Project shell: bash run: | From e96ba28879287b6b4ca6d02d36812e6a97430979 Mon Sep 17 00:00:00 2001 From: hxperl <16929288+hxperl@users.noreply.github.com> Date: Fri, 11 Sep 2026 13:36:06 +0900 Subject: [PATCH 3/3] Unbacktick the `target` parameter name so DocC recognises it `FileDescriptor.duplicate(as:retryOnInterrupt:)` writes its first parameter entry as ``- `target`:`` rather than `- target:`. DocC matches parameter documentation by the bare identifier, so the backticked entry is not associated with the parameter: the description is dropped from the rendered parameter list and DocC reports the parameter as undocumented. The `duplicate(as:options:retryOnInterrupt:)` overload twenty lines below documents the same parameter without backticks, which is what this changes the first overload to match. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01MDv2d3fEYCVWGpu7AgD4qq --- Sources/System/FileOperations.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/System/FileOperations.swift b/Sources/System/FileOperations.swift index 1c7af68..746e6ae 100644 --- a/Sources/System/FileOperations.swift +++ b/Sources/System/FileOperations.swift @@ -381,7 +381,7 @@ extension FileDescriptor { /// Duplicates this file descriptor and returns the newly created copy. /// /// - Parameters: - /// - `target`: The desired target file descriptor, or `nil`, in which case + /// - target: The desired target file descriptor, or `nil`, in which case /// the copy is assigned to the file descriptor with the lowest raw value /// that is not currently in use by the process. /// - retryOnInterrupt: Whether to retry the duplicate operation