Commit Graph
145 Commits
Author SHA1 Message Date
Franz Busch 8d19278bde Wait for the docker daemon on Windows (#3520)
Sometimes the docker daemon on Windows runners isn't ready immediately.
This adds a step to wait for it to become ready.
2026-02-26 10:18:47 +01:00
Rick Newton-Rogers 535c2f8260 switch from main to 0.0.7 for swiftlang workflows (#3514)
Motivation

* `@main` references to `swiftlang/github-workflows` are deprecated.

Modifications

* Replace `@main` with `@0.0.7` in all workflow files.

Result

* Workflow files reference a pinned version of
`swiftlang/github-workflows`.
2026-02-20 13:40:26 +00:00
Franz Busch c90e69406b Fix Xcode 26.2 CI copy and paste error (#3499) 2026-01-28 16:32:30 +00:00
Franz Busch d1aaf4371a Add support for Xcode 26.2 (#3498)
Adds the required new inputs to the macOS tests and benchmark reusable
workflows
2026-01-28 16:47:02 +01:00
dependabot[bot] b2a14468d9 Bump actions/checkout from 6.0.1 to 6.0.2 (#3493)
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.1
to 6.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/releases">actions/checkout's
releases</a>.</em></p>
<blockquote>
<h2>v6.0.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Add orchestration_id to git user-agent when ACTIONS_ORCHESTRATION_ID
is set by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/2355">actions/checkout#2355</a></li>
<li>Fix tag handling: preserve annotations and explicit fetch-tags by <a
href="https://github.com/ericsciple"><code>@​ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2356">actions/checkout#2356</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v6.0.1...v6.0.2">https://github.com/actions/checkout/compare/v6.0.1...v6.0.2</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's
changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v6.0.2</h2>
<ul>
<li>Fix tag handling: preserve annotations and explicit fetch-tags by <a
href="https://github.com/ericsciple"><code>@​ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2356">actions/checkout#2356</a></li>
</ul>
<h2>v6.0.1</h2>
<ul>
<li>Add worktree support for persist-credentials includeIf by <a
href="https://github.com/ericsciple"><code>@​ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2327">actions/checkout#2327</a></li>
</ul>
<h2>v6.0.0</h2>
<ul>
<li>Persist creds to a separate file by <a
href="https://github.com/ericsciple"><code>@​ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2286">actions/checkout#2286</a></li>
<li>Update README to include Node.js 24 support details and requirements
by <a href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/2248">actions/checkout#2248</a></li>
</ul>
<h2>v5.0.1</h2>
<ul>
<li>Port v6 cleanup to v5 by <a
href="https://github.com/ericsciple"><code>@​ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2301">actions/checkout#2301</a></li>
</ul>
<h2>v5.0.0</h2>
<ul>
<li>Update actions checkout to use node 24 by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2226">actions/checkout#2226</a></li>
</ul>
<h2>v4.3.1</h2>
<ul>
<li>Port v6 cleanup to v4 by <a
href="https://github.com/ericsciple"><code>@​ericsciple</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2305">actions/checkout#2305</a></li>
</ul>
<h2>v4.3.0</h2>
<ul>
<li>docs: update README.md by <a
href="https://github.com/motss"><code>@​motss</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li>
<li>Add internal repos for checking out multiple repositories by <a
href="https://github.com/mouismail"><code>@​mouismail</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li>
<li>Documentation update - add recommended permissions to Readme by <a
href="https://github.com/benwells"><code>@​benwells</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li>
<li>Adjust positioning of user email note and permissions heading by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2044">actions/checkout#2044</a></li>
<li>Update README.md by <a
href="https://github.com/nebuk89"><code>@​nebuk89</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li>
<li>Update CODEOWNERS for actions by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/2224">actions/checkout#2224</a></li>
<li>Update package dependencies by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li>
</ul>
<h2>v4.2.2</h2>
<ul>
<li><code>url-helper.ts</code> now leverages well-known environment
variables by <a href="https://github.com/jww3"><code>@​jww3</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1941">actions/checkout#1941</a></li>
<li>Expand unit test coverage for <code>isGhes</code> by <a
href="https://github.com/jww3"><code>@​jww3</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1946">actions/checkout#1946</a></li>
</ul>
<h2>v4.2.1</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a
href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a
href="https://github.com/lucacome"><code>@​lucacome</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependency updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>- <a
href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>,
<a
href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4
updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a
href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable
version. by <a href="https://github.com/jww3"><code>@​jww3</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/checkout/commit/de0fac2e4500dabe0009e67214ff5f5447ce83dd"><code>de0fac2</code></a>
Fix tag handling: preserve annotations and explicit fetch-tags (<a
href="https://redirect.github.com/actions/checkout/issues/2356">#2356</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/064fe7f3312418007dea2b49a19844a9ee378f49"><code>064fe7f</code></a>
Add orchestration_id to git user-agent when ACTIONS_ORCHESTRATION_ID is
set (...</li>
<li>See full diff in <a
href="https://github.com/actions/checkout/compare/8e8c483db84b4bee98b60c0593521ed34d9990e8...de0fac2e4500dabe0009e67214ff5f5447ce83dd">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=6.0.1&new-version=6.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-26 09:24:06 +00:00
Vladimir Kukushkin c534a13dcb Update macOS runners to Tahoe (#3489)
Sequoia runners are no longer available and we need to switch to Tahoe.

### Motivation:

Sequoia runners are no longer available and jobs requesting them hang.

### Modifications:

Request Tahoe runners.

### Result:

Jobs no longer hang, macOS tests and benchmarks are running on Tahoe.
2026-01-22 15:54:50 +01:00
Mike DrobandRick Newton-Rogers 192616d47e Disable Xcode-beta builds until one is installed (#3446)
Xcode-latest currently points to the 26.1 release so it gives us a false
sense of version coverage, and should be ignored.

### Motivation:

We do not need to build twice with the same environment.

### Modifications:

Set default value for Xcode latest beta enabled to `false`

### Result:

One fewer job generated for the macOS build matrix.

Co-authored-by: Rick Newton-Rogers <rnro@apple.com>
2026-01-14 13:42:44 +00:00
Honza Dvorsky d779d6d104 Revert "Address potential template injection issues" (#3478)
Reverts apple/swift-nio#3466 - it broke CI in downstream projects.
2026-01-13 09:45:06 +00:00
Mike Drob 5ada77dafa Address potential template injection issues (#3466)
Instead of evaluating inputs directly in the run step, save them to an
environment variable and evaluate that.

### Motivation:

Evaluating workflow inputs directly can lead to injection attacks, such
as those described at https://docs.zizmor.sh/audits/#template-injection

### Modifications:

Evaluate workflow inputs as environment variables so that they do not
inadvertently execute arbitrary shell injections.

### Result:

The workflows should be more secure against malicious inputs.
2026-01-12 19:52:59 +00:00
Mike Drob 92a262f376 ci: only run self-hosted ci on apple runners (#3468)
Limit Darwin Job execution to apple org.

### Motivation:

When the repo is forked, the forks do not have access to the self-hosted
CI, so it should not block actions in the forked environment.

### Modifications:

Conditionalize Darwin job execution.

### Result:

macOS CI will not queue on forks.
2025-12-23 08:11:06 +00:00
Vladimir Kukushkin 27146d4844 Extract macOS benchmarks into a separate reusable workflow (#3461)
Extract macOS benchmarks into a separate reusable workflow to completely
remove them if they are not meant to be used.

### Motivation:

macOS Benchmarks is an opt-in workflow. If no macOS versions selected to
run benchmarks on, there is now a skipped matrix jobs, creating
unnecessary visual and cognitive noise during workflow results analysis:

<img width="391" height="369" alt="Screenshot 2025-12-10 at 14 22 50"
src="https://github.com/user-attachments/assets/959ff2a1-3872-4bff-97ac-1dca6d2d4ea5"
/>

### Modifications:

macOS benchmarks workflow is extracted into a separate reusable
workflow.

### Result:

- If a repo is not running macOS benchmarks, there is no extra skipped
jobs.
- When willing to run macOS benchmarks, `macos_benchmarks.yml` workflow
should be used.
- This is a breaking change in the reusable workflows interface, so all
the repos (just the `swift-log`?) need to adopt the new reusable
workflow.


Test runs:
- old workflow run with [unused macOS benchmarks skipped and
visible](https://github.com/apple/swift-nio/actions/runs/20102000384/job/57675171794)
- new workflow run with [no macOS benchmarks
visible](https://github.com/apple/swift-nio/actions/runs/20102837431)
because they are not used
- new workflow run with actually [executed and visible macOS
benchmarks](https://github.com/apple/swift-nio/actions/runs/20103726421)
2025-12-11 11:31:36 +00:00
Mike Drob 03ec49f001 update actions/checkout and introduce dependabot (#3459)
Update the actions/checkout action to the latest release (v6.0.1)

### Motivation:

https://github.com/actions/checkout?tab=readme-ov-file#whats-new

> * Improved credential security: persist-credentials now stores
credentials in a separate file under $RUNNER_TEMP instead of directly in
.git/config
> * No workflow changes required — git fetch, git push, etc. continue to
work automatically
> * Running authenticated git commands from a [Docker container
action](https://docs.github.com/actions/sharing-automations/creating-actions/creating-a-docker-container-action)
requires Actions Runner
[v2.329.0](https://github.com/actions/runner/releases/tag/v2.329.0) or
later
> * Updated to the node24 runtime
This requires a minimum Actions Runner version of
[v2.327.1](https://github.com/actions/runner/releases/tag/v2.327.1) to
run.

### Modifications:

Updated the dependency version and added dependabot to take care of
future upgrades.

### Result:

Our workflows will be more secure!
2025-12-08 16:25:40 +00:00
Vladimir Kukushkin 206dacff8e Do not run the matrix if there is no macOS versions picked for benchmarks (#3450)
After the recent addition of macOS-based benchmarks, the `main` workflow
has been failing with:

```
Error when evaluating 'strategy' for job 'benchmarks-macos'. apple/swift-nio/.github/workflows/benchmarks.yml@main (Line: 239, Col: 15): Matrix vector 'config' does not contain any values
```

This happens because `swift-nio` does not set any `_enabled` flag for
any version of Xcode to run the benchmarks.

An example of a failed run:
https://github.com/apple/swift-nio/actions/runs/19479529118

### Motivation:

Scheduled jobs should not fail.

### Modifications:

Added a condition for running macOS benchmarks matrix generation job.

### Result:

Jobs should not fail without any Xcode versions picked for running
benchmarks.

An example of a run with macos-matrix job skipped:
https://github.com/apple/swift-nio/actions/runs/19482328681/job/55758816398
An example of a run with a opt-in macOS Benchmarks:
https://github.com/apple/swift-nio/actions/runs/19484086327/job/55762298924
2025-11-19 11:48:44 +00:00
Vladimir Kukushkin 6dae9889c4 Run benchmarks in CI on macOS in addition to linux (#3444)
Run benchmarks on macOS in addition to Linux.

### Motivation:

1. macOS and Linux benchmark yield different results and we would like
to rack both of them.
2. default Linux GitHub workers do not provide access to PMU, which is
necessary for instructions metric benchmarking

### Modifications:

- `benchmarks.yml` workflow support running benchmarks on self-hosted
macOS runners

### Result:

Benchmarks are running on both linux and macOS runners. An example of an
opt-in PR running just one Xcode version:
https://github.com/apple/swift-nio/actions/runs/19468002318/job/55707591945.

An example of an opt-in PR and thresholds expectations check failed:
https://github.com/apple/swift-nio/actions/runs/19468236909/job/55708359111

I've been running `swift-nio` benchmarks on macOS runners and it is much
less stable than Linux for allocations and context switches. I suggest
we make this an opt-in feature and take in only for instructions count
benchmarks, for example upcoming to the `swift-log`. This also makes it
less stressful for macOS runners pool.
2025-11-18 14:56:53 +00:00
Rick Newton-Rogers 74e77dad61 Switch test targets in macos_tests.yml (#3437)
### Motivation:

The Watch Series 10 and iPhone 16 Pro simulators haven't been working
for some time

### Modifications:

Swap the iOS and macOS test targets

### Result:

Testing against simulators should work

Here is an example of the change in action. The new targets can be
discovered but one of the Xcodes then hits an unrelated issue
https://github.com/apple/swift-nio/actions/runs/19130486127/job/54672071880?pr=3437
2025-11-06 13:33:17 +00:00
Rick Newton-Rogers aa3bf227dd Add Xcode 26.1 to macOS CI (#3438)
### Motivation:

Xcode 26.1 has been released so our support window slides forwards.

### Modifications:

* Add Xcode 26.1 job
* Log Xcode and swift versions for debugging purposes

### Result:

Current Xcode support window, easier debugging.

**NOTE:** we will soon disable Xcode 16.3 by default but will give
adopters time to update their PR status checks first

An example of this in action
https://github.com/apple/swift-nio/actions/runs/19129667587/job/54667112541?pr=3438
2025-11-06 11:38:40 +00:00
Rick Newton-Rogers d373d41637 Swift SDK installation script improvements (#3429)
Swift SDK installation script improvements
  
  ### Motivation:
  
The SDK installation scripts had a few rough edges and didn't verify the
  artefacts they downloaded.
  
  ### Modifications:
  
  * Change naming to the more accurate "Swift SDK" where we can without
    breaking downstream adopters.
  * Separate Android NDK installation into its own script.
  * Avoid using `cd` when setting up Android NDK.
  * Verify checksums for SDKs and signatures for toolchains.
  * Specify/control the SDK directory.
  
  ### Result:
  
  * More accurate naming.
  * More maintainable scripts.
  * More secure downloads.

An example of this working
https://github.com/apple/swift-nio/actions/runs/18944235613/job/54090944716?pr=3429
2025-10-30 17:50:17 +01:00
Marc Prud'hommeaux a24771a4c2 Fix the Android CI workflow by adding a post-install step the configure the SDK (#3424)
Fixes the Android CI workflow

### Motivation:

The recently-added Android SDK workflow
[fails](https://github.com/apple/swift-nio/actions/runs/18718487605/job/53384086329?pr=3418)
(as mentioned at
https://github.com/apple/swift-nio/pull/3418#issue-3540969388). The
confusing error message is due to a post-install step that is needed to
download and link the Android NDK into the Swift SDK's artifactbundle.

This PR also adds a one-line fix to
[Sources/NIOPerformanceTester/main.swift](https://github.com/apple/swift-nio/compare/main...swift-android-sdk:swift-nio:main#diff-de179adbbfacb89c9533f4efd21f7f641eedc0c8642d7d650cdfc9d9278a7a55)
that gets it building for Android so the entire swift-nio package can be
built.

### Modifications:

Adds a post-install step to the SDK installation that is needed for the
Swift SDK for Android. This is the same technique used by
https://github.com/swiftlang/github-workflows/pull/172, and is described
as a necessary step in the [Android getting started
guide](https://github.com/swiftlang/swift-org-website/blob/0dc655ce267e7b6bada2a2032cc7855c3b5e19d9/documentation/articles/swift-android-getting-started.md)

### Result:

The "Android Swift SDK" CI check should now pass successfully. See an
example at
https://github.com/swift-android-sdk/swift-nio/actions/runs/18761057590/job/53525442382

### Note:

This PR will _not_ pass the Android check until it has been merged,
because it relies on being able to down the the script
https://raw.githubusercontent.com/apple/swift-nio/main/scripts/install_swift_sdk.sh
from `apple/swift-nio/main`, which will not include the Android fix
until the PR is merged. But once it is merged, the Android SDK CI should
start passing.
2025-10-30 10:04:17 +00:00
Rick Newton-Rogers 52296f555a Update main.yml to refer to wasm_swift_sdk.yml (#3425)
Update main.yml to refer to wasm_swift_sdk.yml after it was recently
renamed
2025-10-27 10:30:17 +00:00
Max Desiatov 603edbaa34 Fix naming in Wasm Swift SDK workflow (#3423)
"SDK" and "Swift SDK" are different concepts, compare `swift build
--help | grep sdk` output, where we have separate CLI options for these
with different meaning:
* SDK is used by Clang and Xcode, with Swift Driver also implementing
the `-sdk` flag. There's no specification for how Clang SDKs are
distributed, thus we don't distribute any Wasm SDK as such.
* Swift SDK is purely a SwiftPM feature, which uses artifact bundles for
distribution. We do distribute Swift SDKs for Wasm.

Same for static Linux BTW, so a separate PR is needed to clean up that
confusion for Musl-related CI workflows.

Additionally, Wasm is not an acronym. Per the Wasm spec
https://webassembly.github.io/spec/core/intro/introduction.html#wasm:
> A contraction of “WebAssembly”, not an acronym, hence not using
all-caps.
2025-10-24 17:06:41 +01:00
Rick Newton-Rogers 102fa28e6b Env var no keys (#3420)
Fix env var support

### Motivation:

The new WASM and Android SDK workflows report an error in CI
```
jq: error (at <stdin>:1): string ("\"$env_var...) has no keys
```

### Modifications:

Construct the matrix separately and include the env var variable.

### Result:

No more issue in logs, env vars are applied

See this in action here:
https://github.com/apple/swift-nio/actions/runs/18719810714/job/53388814243?pr=3420
2025-10-23 09:42:42 +01:00
Rick Newton-Rogers 412a870a93 Android SDK Workflow (#3418)
### Motivation:

Android SDKs now exist and testing is good.

### Modifications:

Add an Android GitHub Actions workflow using the latest nightly image
and enable it in NIO targetting NIOCore (matching WASM testing).

### Result:

More reusable workflows and more test coverage for NIO

See this in action here (the CI job works but NIOCore fails to build):
https://github.com/apple/swift-nio/actions/runs/18718487605/job/53384086329?pr=3418
2025-10-22 15:00:34 +01:00
e46b29f349 WASM SDK GitHub Actions workflows use NIO matrix (#3417)
WASM SDK GitHub Actions workflows use NIO matrix rather than the
swiftlang one

### Motivation:

Using the NIO one is more in line with the surrounding workflows and
surfaces a simpler UI (possible jobs which aren't run don't appear in
the UI)

### Modifications:

Pull in changes from https://github.com/apple/swift-nio/pull/3159 and
add in the ability to specify environment variables and other build
arguments in line with the static Linux SDK workflow.

### Result:

More regularity, simpler checks UI.

See this in action here:
https://github.com/apple/swift-nio/actions/runs/18717131164/job/53379323803?pr=3417

---------

Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
2025-10-22 14:22:24 +01:00
Rick Newton-Rogers 843c8cf264 Don't generate matrix jobs for Swift versions which aren't supported by the package. (#3415)
Don't generate matrix jobs for Swift versions which aren't supported by
the package.

### Motivation:

Matrix workflows should not generate jobs for Swift versions < tools
version, doing so wastes compute and adds noise.

This means that:
- New repos don’t need to manually opt-out of old Swift versions
- Repos which have dropped an old Swift version (during a migration
window) won’t have failing tests until it’s turned off centrally.

### Modifications:

- The generate script now looks for `Package.swift` and
`Package@swift-*.swift` files and uses the lowest tools version in any
found file to determine the minimum supported Swift version
- Any Swift version lower than the minimum is disregarded and no jobs
are generated for it
- A new parameter is added to the workflows which allows the minimum
Swift version to be set manually (`minimum_swift_version`)

### Result:

By default in this and downstream packages we don't generate matrix jobs
for Swift versions which aren't supported by the package.


An example of this working:
https://github.com/apple/swift-nio/actions/runs/18711362977/job/53360387720?pr=3415
2025-10-22 11:40:01 +01:00
Rick Newton-Rogers 4e8f4b1c9a Enable Xcode beta by default in macos_tests.yml (#3401)
26.1 Beta 2 has been released so we have an Xcode beta to be testing, we
should enable it by default again. It was previously disabled under the
impression that there was no current beta.
2025-10-09 16:31:10 +01:00
Melissa Kilby dee7095f8d set explicit permissions for GitHub workflows - all remaining workflows (#3396)
See https://github.com/apple/swift-nio/issues/3386

Note: I consistently placed the permissions key at the top (slightly
corrected recent PRs).

CC @rnro

Signed-off-by: Melissa Kilby <mkilby@apple.com>
2025-10-07 11:31:35 +01:00
Melissa KilbyandRick Newton-Rogers 2b3140a59c update: set explicit permissions for GitHub workflows - unit-tests (#3388)
See https://github.com/apple/swift-nio/issues/3386
CC @FranzBusch @ktoso @Lukasa

Signed-off-by: Melissa Kilby <mkilby@apple.com>
Co-authored-by: Rick Newton-Rogers <rnro@apple.com>
2025-10-02 14:27:33 +00:00
Melissa Kilby 0c2869d9a2 update: set explicit permissions for GitHub workflows - execute-matri… (#3391)
See https://github.com/apple/swift-nio/issues/3386
CC @FranzBusch @ktoso @Lukasa

Signed-off-by: Melissa Kilby <mkilby@apple.com>
2025-10-02 13:50:44 +00:00
Melissa Kilby 8c359a17d8 update: set explicit permissions for GitHub workflows - release-builds (#3390)
See https://github.com/apple/swift-nio/issues/3386
CC @FranzBusch @ktoso @Lukasa

Signed-off-by: Melissa Kilby <mkilby@apple.com>
2025-10-02 11:51:15 +00:00
Melissa KilbyandRick Newton-Rogers f5a2e752e1 update: set explicit permissions for GitHub workflows - benchmarks (#3389)
See https://github.com/apple/swift-nio/issues/3386
CC @FranzBusch @ktoso @Lukasa

Signed-off-by: Melissa Kilby <mkilby@apple.com>
Co-authored-by: Rick Newton-Rogers <rnro@apple.com>
2025-10-02 11:27:33 +00:00
Melissa Kilby 662d3ddd84 update: set explicit permissions for GitHub workflows - cxx-interop (#3387)
See https://github.com/apple/swift-nio/issues/3386
CC @FranzBusch @ktoso @Lukasa

Signed-off-by: Melissa Kilby <mkilby@apple.com>
2025-10-02 12:00:17 +01:00
Rick Newton-Rogers db496205af Static sdk allow custom args (#3377)
Allow custom argument specification in the Static SDK workflow

### Motivation:

Sometimes users may want to specify more/different parameters such as
specifying building only some targets

### Modifications:

Add a parameter for the build arguments

### Result:

More flexible SDK CI.

You can see this in action here
https://github.com/apple/swift-nio/actions/runs/17858707940/job/50783709148?pr=3377
2025-09-23 14:23:32 +00:00
Cory Benfield f2ebedb36a The formatter changed its mind (#3379) 2025-09-23 14:58:24 +01:00
Rick Newton-Rogers 154706efd3 Matrix custom env vars (#3376)
Allow the specification of custom environment variables in our matrix
workflow and those which use it.

### Motivation:

It can be useful to supply custom environment variables to control build
and runtime options.

### Modifications:

Allow users to supply a string of custom environment variable key-value
pairs which are supplied to the docker container running the matrix
commands.

To attempt to avoid issues with this string concatenation the change
also allows the user to specify custom list entry and key-value-pair
separators.

To avoid parameter bloat the env vars are set for all Swift versions,
hopefully that's sufficient for now.

### Result:

Adopters can 

Examples of this working on Linux and Windows, note the presence of the
test environment variables I injected:
-
https://github.com/apple/swift-nio/actions/runs/17917619451/job/50943847555?pr=3376
- https://github.com/apple/swift-crypto/pull/413/checks

e.g. 
```
Executing Docker command: docker run -v /home/runner/work/swift-nio/swift-nio:/swift-nio -w /swift-nio -e CI=true -e GITHUB_ACTIONS=true -e SWIFT_VERSION=6.0 -e workspace=/swift-nio -e TEST_DEBUG=1 -e TEST_LOG_LEVEL=info swift:6.0-jammy bash -c swift --version && swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error
```
2025-09-22 16:06:47 +01:00
Fabian Fett 6c114e3c62 Update CI scripts for 6.2 (#3374)
Replaces: #3373
2025-09-19 13:55:48 +01:00
Rick Newton-Rogers 325c3231cf Add Xcode 26.0, 16.4 CI, remove 16.2 (#3375)
### Motivation:

New Xcodes are out so we should test with them.

### Modifications:

Update the macOS matrix generation script

### Result:

Add Xcode 26.0, 16.4 CI, remove 16.2 jobs by default.

CI with the new Xcodes working (except 26.0 which will come online as
nodes recycle
https://github.com/apple/swift-nio/actions/runs/17834807139/job/50709176060?pr=3375)
2025-09-19 09:30:08 +01:00
Yuta Saito f92485e959 [wasm][2/2] Include WebAssembly SDK checks in PR and main workflows (#3332)
Add build check CI for WebAssembly SDK

### Motivation:

Add build check CI for WebAssembly SDK

### Modifications:

Add Wasm build checks in `main.yml` and `pull_request.yml` based on
https://github.com/apple/swift-nio/pull/3331

Extracted from https://github.com/apple/swift-nio/pull/3159

### Result:

Setting up the CI job makes it easier to detect such incompatibility
before merging.
2025-08-11 13:06:50 +01:00
Yuta Saito a114cfb471 [wasm][1/2] Add reusable WebAssembly workflow (#3331)
Add build check CI for WebAssembly SDK

### Motivation:

Add build check CI for WebAssembly SDK

### Modifications:

Add only reusable GHA workflow from
https://github.com/apple/swift-nio/pull/3159 to gracefully merge changes
without breaking CI.

After this change being merged into main branch, we can merge the actual
PR checks: https://github.com/apple/swift-nio/pull/3331

### Result:

Setting up the CI job makes it easier to detect such incompatibility
before merging.
2025-08-04 14:10:02 +00:00
Rafael Cepeda 02be63c7f4 Fixes all warnings when -require-explicit-sendable flag is enabled (#3320)
Fixes all warnings when `-require-explicit-sendable` flag is enabled and
enables the flag on macOS CI.

### Motivation:

We want to ensure our public API is either explicitly marked as
`Sendable` or not.

### Modifications:

Marked appropriate public types as `Sendable`, or explicitly defined
their conformance to the `Sendable` protocol as unavailable.

### Result:

We can now enable `-require-explicit-sendable` compiler flag in our
codebase.
2025-07-30 11:50:28 +01:00
Raphael 95c91a42a9 Enable release mode builds (#3327)
### Motivation:

Some errors do not show up in debug builds. Enabling release mode builds
improves the CI coverage.

### Modifications:

Enable release mode builds for pull requests and scheduled builds on
main.

### Result:

Improved CI coverage.
2025-07-30 08:59:02 +01:00
Raphael e0ef60bb98 Do not run windows nightly CI by default (#3325)
### Motivation:

Not everything that relies on these workflows builds on windows. Unit
tests and release builds should be explicitly enabled for windows
builds.

### Modifications:

Change default of windows nightly to false. Fix flag checks that enable
nightly builds.

### Result:

Easier to use CI workflows.
2025-07-29 14:49:04 +01:00
Raphael 6b48b36c7e Add workflow for release mode builds(#3321)
Add a new workflow file for release mode builds

### Motivation:

Some errors do not show up in debug builds. Running release mode builds
improves the CI coverage.

### Modifications:

Add a new workflow for release mode builds.

### Result:

Projects can build on this workflow to enable release mode builds.
2025-07-29 10:35:10 +01:00
Mike DrobandCory Benfield b8b1940bd5 Move conditional setup logic from bash to actions (#3313)
Instead of checking for a setup command in bash, we use GitHub Actions
to determine if there is anything to run

### Motivation:

Slightly cleaner output when looking at logs.

### Modifications:

Moved an if statement from bash to yaml.

### Result:

The setup commands step will generally be skipped instead of executing a
no-op

Co-authored-by: Cory Benfield <lukasa@apple.com>
2025-07-22 14:38:38 +00:00
George Barnett 66483af202 Pick visionOS version for Xcode 16.2 (#3307)
Motivation:

The nightly visionOS tests are failing because there
are too many simulators matching the given destination 
selector.

Modifications:

- On Xcode 16.2 use visionOS 2.3

Result:

Nightly CI passes
2025-07-17 13:24:44 +01:00
Mike Drob 83bc5b5844 chore: avoid spurious xcodebuild warning (#3291)
Specify default macOS variant in non-catalyst builds.

https://developer.apple.com/forums/thread/737851

### Motivation:

macOS build has an extra warning:

```
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, name:Any Mac }
{ platform:macOS, variant:Mac Catalyst, name:Any Mac }
```

### Modifications:

Explicitly select the macOS variant.

### Result:

No warnings
2025-07-09 09:35:31 +01:00
Rick Newton-Rogers 09030f291f Make use of symlink to latest Xcode beta (#3285)
### Motivation:

The macOS runners have a symlink to the latest released Xcode beta at
Xcode-latest.app, by making use of it we will always test against the
most recent version.

### Modifications:

Introduce new parameters for the latest Xcode beta and deprecate those
which mention Xcode 21 betas.

### Result:

Tests will move on to using Xcode 26 beta 2 via the symlink

Example of this working
https://github.com/apple/swift-nio/actions/runs/16075841548/job/45370760690?pr=3285
2025-07-04 16:12:08 +01:00
Rafael Cepeda 89be322fe8 Fixed issue with macOS CI when overrides are being used. (#3270)
Fixed issue with macOS CI when overrides are being used.

### Motivation:

When we use Xcode_XX_X_build_arguments_override, the CI fails because of
an extra double quotes ("") making its way to the final command.

### Modifications:

Remove the extra double quote from the Yaml file defining macOS tests.

### Result:

We are able to run `swift build` with extra arguments.
2025-06-20 11:24:21 +01:00
Rick Newton-Rogers d24d9ab882 Add Xcode 26 beta 1 to macOS CI (#3267)
Add Xcode 26 beta 1 to macOS CI and disable Xcode 16.1 jobs by default

### Motivation:

* Xcode 26 beta 1 is now released, we should test our code on it.
* We should drop 16.1 to conserve the number of jobs. 16.1 isn't
offering much coverage anyway since it has the same Swift minor version
(6.0) as Xcode 16.2.

### Modifications:

* Enable use of Xcode 26 beta 1 by default.
* Disable Xcode 16.1 jobs by default

### Result:

* This and downstream repos will run Xcode builds on Xcode 26 beta 1.
* Xcode 16.1 jobs won't run by default on this or downstream repos but
will run if explicitly requested.

An example of this working
https://github.com/apple/swift-nio/actions/runs/15614383580/job/43983277904?pr=3267
2025-06-12 15:46:48 +00:00
Rick Newton-RogersandGeorge Barnett e3e1cb50ec Benchmarks workflow prints diff when changes found (#3258)
### Motivation:

The current method of parsing the ASCII table output is brittle and
because the text output and the stored thresholds in JSON have different
precisions doesn't always work.

### Modifications:

* In the event that a deviation is found re-run the benchmarks in update
mode and print the git diff to the logs.
* The threshold update script scrapes this from the logs and applies it
locally so that it can then be committed.
* Add the functionality in the update script to update thresholds based
on diff in logs

### Result:

More reliable threshold updates.

An example of this working:
https://github.com/apple/swift-nio/actions/runs/15302748893?pr=3257

---------

Co-authored-by: George Barnett <gbarnett@apple.com>
2025-05-29 14:29:52 +00:00
Rick Newton-Rogers 8317eabea0 Retry curl operations in CI scripts (#3256)
### Motivation:

Some 429: Too many requests responses have been seen when attempting to
curl remote CI scripts.

### Modifications:

Adding `--retry 3` which means that curl will retry 3 times on transient
error codes.

### Result:

Transient errors will be retried 3 times, first for 1 second and then
doubled each retry.

From `man curl`
```
       --retry <num>
              If a transient error is returned when curl tries to perform a transfer, it
              retries this number of times before giving up. Setting the number to 0
              makes curl do no retries (which is the default). Transient error means
              either: a timeout, an FTP 4xx response code or an HTTP 408, 429, 500, 502,
              503 or 504 response code.

              When curl is about to retry a transfer, it first waits one second and then
              for all forthcoming retries it doubles the waiting time until it reaches 10
              minutes which then remains delay between the rest of the retries. By using
              --retry-delay you disable this exponential backoff algorithm. See also
              --retry-max-time to limit the total time allowed for retries.

              curl complies with the Retry-After: response header if one was present to
              know when to issue the next retry (added in 7.66.0).

              If --retry is provided several times, the last set value is used.
```
2025-05-28 15:14:10 +01:00