mirror of
https://github.com/apple/swift-http-types
synced 2026-11-22 04:30:40 +00:00
### Motivation #144 introduced a regression in `HTTPField.Name(parsed:)`. HTTP/2 and HTTP/3 require field names to be lowercased on the wire (RFC 9113 § 8.2.1, RFC 9114 § 4.1.2). Previously we enforced this by only accepting lowercase ASCII letters. In #144 we replaced a specific scan with `HTTPField.isValidToken`, which is shared in multiple token validation places and returns `valid` for uppercased names. We checked for `isValid`, which is true for `valid` as well as `canonical` representations. Allowing `valid` and not just `canonical` representations is the regression. This lead to this unwanted behavior: - `HTTPField.Name(parsed: "Content-Type")` now succeeds, so a decoder can no longer detect the malformed message it has to reject. - The returned name violates the documented invariant that `canonicalName` is lowercased, so it compares and hashes unequal to `HTTPField.Name("Content-Type")`, which does canonicalise. This path had no test coverage, so neither regression was caught. ### Changes Require `.canonical` rather than merely valid token validity in `init(parsed:)`, restoring the pre-#144 behavior, and document why. Add `HTTPFieldNameTests` covering both initializers: valid names, pseudo header fields, invalid characters, the mixed-case canonicalisation that `init(_:)` performs, and the uppercase rejection that `init(parsed:)` performs. ### Result `init(parsed:)` rejects uppercased names again and `canonicalName` is lowercased for every name it returns.